detach io thread output from creation cell #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, this isn't quite right. Need to figure out if I can make a test |
use a Thread subclass that immediately undoes the output routing after it is applied
minrk
force-pushed
the
client-thread-output
branch
from
51ae59f
to
e534ef1
Compare
|
added more thorough workaround to totally disable ipykernel's wrong output routing for all threads we create. Reported need for public API (and likely different defaults) as ipython/ipykernel#1289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipykernel has started associating thread output with the Cell that spawned the Thread (ipython/ipykernel#1186), but that sends output to the wrong cell for cells that are meant to stream to the current output area.
there is currently no opt-out for this, so we have to delete the association after it is created
There should be a public API to disable this for specific Threads, but until then disable the private association after it is created
fixes #893
An alternative (and possibly better?) fix is to explicitly route outputs from the io thread to the main thread, but that's tricky with event loops.