Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to make implementations of some function always return awaitable #1295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Nov 13, 2024

  1. Suggest to make implementations of some function always return awaita…

    …ble.
    
    See discussion in ipython#1272; It is not deprecated, but being able to always
    know you can (and must) await should be simpler in the long run.
    
    Deprecating now is not the point, but I want to cover our bases, so
    that we are more confident later when and if we want to enforce those await.
    
    In particular many of those branches are not covered in our tests – and
    I don't even know wether they were ever taken;
    
    I changed some of the base methods to be async, but I'm happy to move
    those back to sync.
    
    A few other things use the `if awaitable(...):` pattern but are a bit
    more complicted, and some do not dates from 2021, so those will be dealt
    with separately.
    Carreau committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    0a69e5f View commit details
    Browse the repository at this point in the history