remove deprecated ipyparallel methods now that they are broken anyway #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no version of ipython parallel without these methods will work with ipykernel 7 anyway
minrk
changed the title
Carreau
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no version of ipython parallel without these methods will work with ipykernel 7 anyway, so might as well remove them since they can never be used.
Restores
should_handleto be sync in the default implementation (it only returns True now that the ipyparallel code is removed), which was an unnecessary breakage. It is allowed to be async in subclasses.alternative to the updated deprecation messages in #1272