Run Mypy by default. #1270
Open
Run Mypy by default. #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the types annotations are less usefull, even with ruff. Ignore/fix types errors.
|
I'm still also super-confused as running mypy directly and running via hatch/precommit gives different results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the types annotations are less usefull, even with ruff.
Ignore/fix types errors.
Also the mypy config was way to lax, ignoring errors project wide intead of per-file.
This make it much stricter and only ignore error on each file, so this types of errors are still confined, and it is easy-ish, to make it a bit more stricter progressively