Fix use of "%matplotlib osx" #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2024
|
Do you have an ETA to release this fix? |
|
@ivanlen It looks like this could be in a release in about 2 weeks time. |
|
@ianthomas23 can you please try running this workflow with the default settings? https://github.com/ipython/ipykernel/actions/workflows/publish-release.yml. It should finalize the draft release I made over the weekend. |
|
@blink1073 Done! Workflow run is https://github.com/ipython/ipykernel/actions/runs/9745716039/job/26894339146 and 6.29.5 is up on PyPI. |
|
Woohoo! |
|
Thanks for your help! |
This was referenced Jul 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1124 which is that the use of
%matplotlib osxcrashesipykerneland downstream libraries whereasipythonis fine.The fix is to specify the
argtypesof eachobjc_msgSendcall just before the call. This is consistent with howipythonsuccessfully handles it. I have tested this manually usingspyderandjupyter console,qtconsole,labandnbclassic: usingipykernel 6.29.4(the latest release) they all crash, using this branch they all work as expected.This PR is opened against the
6.xbranch rather thanmainas issue #1235 means it is not possible to test anymatplotlibGUI loops onmain. It would be good to get this into a release (6.29.5?) as soon as possible and not have to wait for #1235 and the other AnyIO fallout issues to be fixed beforehand. This PR will therefore need to be forward ported tomain.There is no explicit test for this as you need to actually render a macos window to trigger the failure, and this is not an easy thing to do on headless CI. Essentially this functionality sits in the grey area between
matplotlibandipython/ipykernel/jupyterrather than in any individual project.