Adjusting PR

Instead of making $trackingId protected, added a function which can set the $trackingId variable
ipunkt · May 3, 2018 · de91101 · de91101
1 parent e1fae2a
commit de91101
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 1 deletion.
diff --git a/src/Ipunkt/LaravelAnalytics/Contracts/AnalyticsProviderInterface.php b/src/Ipunkt/LaravelAnalytics/Contracts/AnalyticsProviderInterface.php
@@ -213,6 +213,15 @@ public function ecommerceAddItem($id, $name, $sku = null, $category = null, $pri
      */
     public function setCustom($dimension, $value = null);
 
+	/**
+	 * set a custom tracking ID (the UA-XXXXXXXX-1 code)
+	 *
+	 * @param string $trackingId
+	 *
+	 * @return AnalyticsProviderInterface
+	 */
+    public function setTrackingId($trackingId);
+
     /**
      * enables Content Security Polity and sets nonce
      *

diff --git a/src/Ipunkt/LaravelAnalytics/Providers/GoogleAnalytics.php b/src/Ipunkt/LaravelAnalytics/Providers/GoogleAnalytics.php
@@ -22,7 +22,7 @@ class GoogleAnalytics implements AnalyticsProviderInterface
      *
      * @var string
      */
-    protected $trackingId;
+    private $trackingId;
 
     /**
      * tracking domain
@@ -733,4 +733,16 @@ protected function _getJavascriptTemplateBlockEnd()
             ? '</script>'
             : '';
     }
+
+	/**
+	 * set a custom tracking ID (the UA-XXXXXXXX-1 code)
+	 *
+	 * @param string $trackingId
+	 *
+	 * @return AnalyticsProviderInterface
+	 */
+	public function setTrackingId( $trackingId ) {
+		$this->trackingId = $trackingId;
+		return $this;
+	}
 }
diff --git a/src/Ipunkt/LaravelAnalytics/Providers/NoAnalytics.php b/src/Ipunkt/LaravelAnalytics/Providers/NoAnalytics.php
@@ -306,4 +306,15 @@ public function cspNonce()
     {
         return null;
     }
+
+	/**
+	 * set a custom tracking ID (the UA-XXXXXXXX-1 code)
+	 *
+	 * @param string $trackingId
+	 *
+	 * @return AnalyticsProviderInterface
+	 */
+	public function setTrackingId( $trackingId ) {
+		return $this;
+	}
 }