Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu: Add static routes per interface instead of a separate single file #1737

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

jbemmel
Copy link
Collaborator

@jbemmel jbemmel commented Jan 3, 2025

Update: Modified to add static routes under each interface separately, such that the interface type is automatically correct

@ipspace
Copy link
Owner

ipspace commented Jan 3, 2025

This PR assumes the nexthop interfaces are all of the same type, which I believe is a safe assumption

Now that we support 'routing' module on Linux, this is no longer a safe assumption.

Copy link
Owner

@ipspace ipspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No shortcuts. A Linux host could (theoretically) have static routes point to bond interfaces and native Ethernet interfaces.

@jbemmel
Copy link
Collaborator Author

jbemmel commented Jan 3, 2025

No shortcuts. A Linux host could (theoretically) have static routes point to bond interfaces and native Ethernet interfaces.

ok, in that case I would propose to add the static routes in /etc/netplan/03-eth-[ifname].yaml instead of that separate single file

This allows for multiple different interface types
@jbemmel jbemmel changed the title Ubuntu: Fix interface type in case of bond Ubuntu: Add static routes per interface instead of a separate single file Jan 3, 2025
@ipspace ipspace merged commit 250cb8f into dev Jan 4, 2025
12 checks passed
@ipspace ipspace deleted the jbemmel-ubuntu-bond-nexthop branch January 4, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants