Fix: check the VLAN/interface fwd mode compatibility #1474
Conversation
Connecting a bridge/IRB interface to two segments of a routed VLAN results in a shared IP prefix used on both segments. This change checks for the forwarding mode mismatch and triggers an error that can be disabled with a defaults setting (because someone might want to use the shared IP prefix) It turns out several routed VLAN transformation tests relied on this behavior, so they got the VLAN default tweak. Fixes #1461
Deploying netlab with
|
| Latest commit: |
1e1e376
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://11605718.netlab.pages.dev |
| Branch Preview URL: | https://dev.netlab.pages.dev |
netsim/defaults/hints.yml
Outdated
| quirks: | ||
| junos_lb: > | ||
| Junos devices cannot have more than one loopback interface per routing instance | ||
|
|
||
| vlan: | ||
| fwd_mode_check: > | ||
| You can disable this error with "defaults.vlan.warnings.mixed_fwd: False", but then |
There was a problem hiding this comment.
It may be confusing to have a "fwd_mode_check" that can be disabled through "mixed_fwd"
Suggestion: Either use mixed_fwd_check or fwd_mode_check for both?
| @@ -2,6 +2,7 @@ | |||
| # of link-, node- and vlan forwarding modes, in particular with mode = route | |||
| # | |||
|
|
|||
| defaults.vlan.warnings.mixed_fwd: False | |||
There was a problem hiding this comment.
Could scope this flag to the vlan for which we want to allow the mixed forwarding, instead of globally?
or introduce a new mode value that represents this behavior, e.g. mode: mixed
There was a problem hiding this comment.
No. This an extremely niche edge case, and the only reason I didn't just shut it down is because every other blue moon someone might have a good reason to do that. I will not make a hierarchy of nerd knobs out of this ;)
How about we condense the user intent into "I want to use netlab the way it was designed" or "I want to do something you guys don't want to hear about and I will not complain about the results" 😇 |
Connecting a bridge/IRB interface to two segments of a routed VLAN results in a shared IP prefix used on both segments.
This change checks for the forwarding mode mismatch and triggers an error that can be disabled with a defaults setting (because someone might want to use the shared IP prefix)
It turns out several routed VLAN transformation tests relied on this behavior, so they got the VLAN default tweak.
Fixes #1461