Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iosxrd caveats #1450

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Update iosxrd caveats #1450

merged 11 commits into from
Oct 28, 2024

Conversation

sdargoeuves
Copy link
Contributor

Linked to issue #1435

Copy link
Owner

@ipspace ipspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ipspace ipspace merged commit 978d247 into ipspace:dev Oct 28, 2024
5 checks passed
@ipspace
Copy link
Owner

ipspace commented Oct 28, 2024

Just FYI: if you're working from an older commit in the dev branch, it might be better to rebase your branch from dev than to merge dev into it because then we get a clean commit history in the PR. Fortunately, it doesn't matter from the final results perspective, it's just a bit easier to understand.

@sdargoeuves sdargoeuves deleted the 1435_iosxrd_caveats branch October 28, 2024 07:24
@sdargoeuves
Copy link
Contributor Author

As you can see, I'm clearly not used to work with fork! I thought I did the rebase, but I did see all the previous commit... you would have seen my several attempts but I was unsuccessful.
I started with a git pull --rebase --prune from my dev branch, then created my new branch. Then after doing the change, I did the git add and git commit, and finally git push origin my_branch

Should I have done this (suggestion by GPT)?
git checkout my-branch
git fetch origin
git rebase origin/dev
git push --force-with-lease origin my-branch

@ipspace
Copy link
Owner

ipspace commented Oct 28, 2024

I started with a git pull --rebase --prune from my dev branch, then created my new branch. Then after doing the change, I did the git add and git commit, and finally git push origin my_branch

That's OK, but the dev branch has changed in the meantime, so you should do git pull --rebase on the dev branch just before you're ready to submit the PR, the git rebase -i dev (I always use the interactive rebase to see what will happen) in your branch to add your new commits at the end of the dev branch, the git push to push your branch back to GitHub, usually with --force or (safer) --force-with-lease

Julia Evans has tons of very useful info on git and rebasing, including https://wizardzines.com/comics/rules-for-rebasing/ and https://jvns.ca/blog/2023/11/06/rebasing-what-can-go-wrong-/ (plus tons of other things on her blog)

@sdargoeuves
Copy link
Contributor Author

Thanks a lot for this, next one should be better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants