-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update iosxrd caveats #1450
Update iosxrd caveats #1450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Just FYI: if you're working from an older commit in the dev branch, it might be better to rebase your branch from dev than to merge dev into it because then we get a clean commit history in the PR. Fortunately, it doesn't matter from the final results perspective, it's just a bit easier to understand. |
As you can see, I'm clearly not used to work with fork! I thought I did the rebase, but I did see all the previous commit... you would have seen my several attempts but I was unsuccessful. Should I have done this (suggestion by GPT)? |
That's OK, but the dev branch has changed in the meantime, so you should do git pull --rebase on the dev branch just before you're ready to submit the PR, the git rebase -i dev (I always use the interactive rebase to see what will happen) in your branch to add your new commits at the end of the dev branch, the git push to push your branch back to GitHub, usually with --force or (safer) --force-with-lease Julia Evans has tons of very useful info on git and rebasing, including https://wizardzines.com/comics/rules-for-rebasing/ and https://jvns.ca/blog/2023/11/06/rebasing-what-can-go-wrong-/ (plus tons of other things on her blog) |
Thanks a lot for this, next one should be better! |
Linked to issue #1435