Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check VLAN/node/interface forwarding mode compatibility #1461

Closed
ipspace opened this issue Oct 29, 2024 · 0 comments · Fixed by #1474
Closed

Check VLAN/node/interface forwarding mode compatibility #1461

ipspace opened this issue Oct 29, 2024 · 0 comments · Fixed by #1474
Assignees
@ipspace
Labels
1.9.2 bug Something isn't working

Comments

@ipspace
Copy link
Owner

ipspace commented Oct 29, 2024

We should check the attempt to downgrade forwarding modes -- if the VLAN has mode: route then no device connected to that VLAN should have VLAN mode set to bridge or irb.

Originally posted by @ipspace in #1457 (comment)
@ipspace ipspace self-assigned this Oct 29, 2024
@ipspace ipspace added bug Something isn't working 1.9.2 labels Oct 29, 2024
ipspace added a commit that referenced this issue Nov 1, 2024
@ipspace
Fix: check the VLAN/interface fwd mode compatibility
901bc93 
Connecting a bridge/IRB interface to two segments of a routed VLAN
results in a shared IP prefix used on both segments.

This change checks for the forwarding mode mismatch and triggers an
error that can be disabled with a defaults setting (because someone
might want to use the shared IP prefix)

It turns out several routed VLAN transformation tests relied on
this behavior, so they got the VLAN default tweak.

Fixes #1461
@ipspace ipspace mentioned this issue Nov 1, 2024
Merged
@ipspace ipspace closed this as completed in f36289e Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipspace ipspace

Labels
1.9.2 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: check the VLAN/interface fwd mode compatibility ipspace/netlab
1 participant
@ipspace