Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
pdobacz committed Sep 26, 2024
1 parent 881ff86 commit 912fc8e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 18 deletions.
15 changes: 0 additions & 15 deletions tests/prague/eip7692_eof_v1/eip7069_extcall/test_calls.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ def test_legacy_calls_eof_sstore(
sender=sender,
to=Address(calling_contract_address),
gas_limit=50000000,
data="",
)

calling_storage = Storage(
Expand Down Expand Up @@ -169,7 +168,6 @@ def test_legacy_calls_eof_mstore(
sender=sender,
to=Address(calling_contract_address),
gas_limit=50000000,
data="",
)

calling_storage = {
Expand Down Expand Up @@ -225,7 +223,6 @@ def test_eof_calls_eof_sstore(
sender=sender,
to=Address(calling_contract_address),
gas_limit=50000000,
data="",
)

calling_storage = Storage(
Expand Down Expand Up @@ -299,7 +296,6 @@ def test_eof_calls_eof_mstore(
sender=sender,
to=Address(calling_contract_address),
gas_limit=50000000,
data="",
)

calling_storage = {
Expand Down Expand Up @@ -365,7 +361,6 @@ def test_eof_calls_precompile(
sender=sender,
to=Address(calling_contract_address),
gas_limit=5000000,
data="",
)

calling_storage = {
Expand Down Expand Up @@ -421,7 +416,6 @@ def test_eof_calls_legacy_sstore(
sender=sender,
to=Address(calling_contract_address),
gas_limit=50000000,
data="",
)

calling_storage = {
Expand Down Expand Up @@ -489,7 +483,6 @@ def test_eof_calls_legacy_mstore(
sender=sender,
to=Address(calling_contract_address),
gas_limit=50000000,
data="",
)

calling_storage = {
Expand Down Expand Up @@ -565,7 +558,6 @@ def test_callee_fails(
sender=sender,
to=Address(calling_contract_address),
gas_limit=4000000,
data="",
)

calling_storage = {
Expand Down Expand Up @@ -637,7 +629,6 @@ def test_callee_context(
sender=sender,
to=Address(calling_contract_address),
gas_limit=100000,
data="",
value=tx_value,
)

Expand Down Expand Up @@ -704,7 +695,6 @@ def test_eof_calls_eof_then_fails(
sender=sender,
to=Address(calling_contract_address),
gas_limit=50000000,
data="",
)

post = {
Expand Down Expand Up @@ -795,7 +785,6 @@ def test_eof_calls_clear_return_buffer(
sender=sender,
to=Address(calling_contract_address),
gas_limit=50000000,
data="",
)

calling_storage = {
Expand Down Expand Up @@ -856,7 +845,6 @@ def test_eof_calls_static_flag_with_value(
sender=sender,
to=Address(calling_contract_address),
gas_limit=5_000_000,
data="",
)

calling_storage = {
Expand Down Expand Up @@ -954,7 +942,6 @@ def test_eof_calls_min_callee_gas(
sender=sender,
to=Address(calling_contract_address),
gas_limit=no_oog_gas + extra_gas_limit,
data="",
)

calling_storage = {
Expand Down Expand Up @@ -1001,7 +988,6 @@ def test_eof_calls_with_value(
sender=sender,
to=Address(calling_contract_address),
gas_limit=50000000,
data="",
)

calling_storage = {
Expand Down Expand Up @@ -1098,7 +1084,6 @@ def test_eof_calls_msg_depth(
sender=sender,
to=Address(calling_contract_address),
gas_limit=gas_limit,
data="",
)

calling_storage = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -638,9 +638,7 @@ def test_eofcreate_context(

destination_contract_address = compute_eofcreate_address(calling_contract_address, 0, initcode)

tx = Transaction(
sender=sender, to=calling_contract_address, gas_limit=1000000, data="", value=value
)
tx = Transaction(sender=sender, to=calling_contract_address, gas_limit=1000000, value=value)

if expected_result == "destination":
expected_bytes: bytes = destination_contract_address
Expand Down

0 comments on commit 912fc8e

Please sign in to comment.