Uniquac dev #117
Merged
Uniquac dev #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavement for the release before EQUIFASE
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #117 +/- ##
==========================================
+ Coverage 93.37% 93.95% +0.58%
==========================================
Files 65 67 +2
Lines 2896 3207 +311
Branches 212 251 +39
==========================================
+ Hits 2704 3013 +309
- Misses 139 140 +1
- Partials 53 54 +1 ☔ View full report in Codecov by Sentry. |
|
joya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modelo UNIQUAC implementado con API Python
Tiene tests desde el lado fortran y el Python (solo corroborar que se obtengan los mismos valores de ln_gamma)
Se implementaron las derivadas dxk_dni y d2xk_dnidnj en el modulo math. No tienen tests particulares, estan testeadas mediante su uso en UNIQUAC.
Veo que el PR tiene un montón más de cambios, el branch lo hice a partir de la main que habiamos cambiado varias cosas de la documentación y el CI, es eso.