Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniquac dev #116

Closed
wants to merge 23 commits into from
Closed

Uniquac dev #116

wants to merge 23 commits into from

Conversation

SalvadorBrandolin
Copy link
Member

Modelo UNIQUAC con API Python

Se crearon test tanto en Fortran como Python (del lado Python solo corroborar que el resultado de ln:gammas sea igual que en Fortran)

Por último, se implementaron las derivadas dxk_dni y d2xk_dnidnj en el modulo math. No tienen tests especificos, se testearon mediante su uso en UNIQUAC.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 99.30556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.90%. Comparing base (0bf8906) to head (0ef45a6).

Files with missing lines Patch % Lines
src/models/excess_gibbs/uniquac.f90 98.83% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #116      +/-   ##
==========================================
+ Coverage   93.37%   93.90%   +0.53%     
==========================================
  Files          65       67       +2     
  Lines        2896     3184     +288     
  Branches      212      251      +39     
==========================================
+ Hits         2704     2990     +286     
- Misses        139      140       +1     
- Partials       53       54       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants