feat(selectors): negative values for slice matcher's From and To #530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: ipld/ipld#289
Builds on the basic fixes and tests in: #529
Note particularly the nuances in the test cases for negative values as they relate to what I outlined in ipld/ipld#289.
One implication of the way this is implemented is that we can't do the "your range didn't match, so we'll give you the full file". We end up with "didn't match, you get nothing (just the root)". Which seems like logical behaviour to me, but @willscott you did bring up the http spec saying that you could return the whole lot if your range is OOB or invalid in some way.