Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: car-* request query parameters #472

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Apr 17, 2024

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Rebased and clarified how they interact with Content-Location.

For anyone following:

  • Documenting use of Content-Location in gateways: document Content-Location #471 allowed us to introduce these query parameters safely, in a way that is backward compatible (Accept header taking priority over format query parameter, Content-Type of response being the final source of truth for the client).
  • No IPIP as these CAR content type parameters were already present in Accept and Content-Type. Documenting their query versions is a formality to allow exposing them in Content-Location, which in turn allows implementations to ensure unique cache key for requests with parameters other than the implicit defaults.
    • tldr: this allows gateways to cache different CAR response variants without overriding each of them

@hacdias hacdias merged commit ca46f40 into gateway-content-location Apr 18, 2024
2 checks passed
@hacdias hacdias deleted the gateway-car-parms branch April 18, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

2 participants