feat: error page when service worker not available #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Jun 5, 2024
src/index.tsx
Outdated
Comment on lines
17
to
23
| let ErrorPage: null | React.LazyExoticComponent<() => React.JSX.Element> = null | ||
| if (navigator.serviceWorker == null) { | ||
| ErrorPage = LazyServiceWorkerErrorPage | ||
| } | ||
|
|
||
| const routes: Route[] = [ | ||
| { default: true, component: LazyHelperUi }, | ||
| { default: true, component: ErrorPage ?? LazyHelperUi }, |
There was a problem hiding this comment.
gives us the ability to easily set different error pages for other conditions, without fronting the loading of all the errors for all users.
|
Updated UI to include the header & about components, and red error display with 
|
2color
reviewed
Jun 13, 2024
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Russell Dempsey <[email protected]>
|
yay, CI finally passed. merging. |
SgtPooki
deleted the
272-user-friendly-error-when-navigatorserviceworker-is-undefined
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
feat: error page when service worker not available
Description
Basic error page implementation for users who don't have serviceWorker available.
Fixes #272
Notes & open questions
Change checklist