Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-friendly error when navigator.serviceWorker is undefined #272

Closed
lidel opened this issue May 23, 2024 · 2 comments · Fixed by #283 or #491
Closed

User-friendly error when navigator.serviceWorker is undefined #272

lidel opened this issue May 23, 2024 · 2 comments · Fixed by #283 or #491
Assignees
@SgtPooki
Labels
bug Something isn't working effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good for newcomers javascript Pull requests that update Javascript code kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Milestone
Prod: Initial rel...

Comments

@lidel
Copy link
Member

lidel commented May 23, 2024

Opening in browser without SW, such as Firefox in incognito, makes it impossible to initialize SW, produces an error in terminal, but no feedback for user on the page – looks stuck in load forever:

2024-05-23_17-18
@lidel lidel added the bug Something isn't working label May 23, 2024
@lidel lidel added this to the Prod: Initial release milestone May 23, 2024
@SgtPooki SgtPooki self-assigned this Jun 5, 2024
@SgtPooki SgtPooki linked a pull request Jun 5, 2024 that will close this issue
feat: error page when service worker not available #283
Merged
3 tasks
@SgtPooki SgtPooki mentioned this issue Jun 5, 2024
Merged
3 tasks
@lidel
Copy link
Member Author

lidel commented Nov 22, 2024 •
edited
Loading

Reopening. It works on main page:

image

but does not work on subdomains:

Repro https://blog-ipfs-tech.ipns.inbrowser.link running production@7b0ebf3:
image

@lidel lidel reopened this Nov 22, 2024
@SgtPooki SgtPooki added good first issue Good for newcomers javascript Pull requests that update Javascript code effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked labels Nov 22, 2024
@SgtPooki
Copy link
Member

got tests for this and fix incoming...

SgtPooki added a commit that referenced this issue Nov 22, 2024
@SgtPooki
test: add no-sw tests that repro #272
cfe7ab4
@SgtPooki SgtPooki linked a pull request Nov 22, 2024 that will close this issue
fix: no-sw error shows for subdomain requests #491
Merged
3 tasks
@SgtPooki SgtPooki mentioned this issue Nov 22, 2024
Merged
3 tasks
SgtPooki added a commit that referenced this issue Nov 22, 2024
@SgtPooki
fix: no-sw error shows for subdomain requests (#491)
c16688e 
* test: enable testing of pages with no service worker loaded

* test: add no-sw tests that repro #272

* fix: no-sw error shows for subdomain requests

* test: no-service-worker tests target a test file & run in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
bug Something isn't working effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good for newcomers javascript Pull requests that update Javascript code kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Projects
None yet
Milestone
Prod: Initial release
2 participants
@lidel @SgtPooki