Basics around deployment #5
Conversation
|
I'm forgetting why we need |
They're only really needed if someone wanted to deploy this to ipfs.io. The last time we looked people were still using them. If that's not true anymore then dropping support everywhere (kubo, bifrost-gateway, here) sounds good. Here's the issue where this was tracked for bifrost-gateway with links to the analysis ipfs-inactive/bifrost-gateway#13. To be fair time has passed though and this might not continue to be valid. |
There was a problem hiding this comment.
I think it is fine to keep newKuboRPCHandler. We've sunk time on this earlier this year and it provides backward-compatibility + metrics that show its use.
(We can remove it later, when we also remove it from gateway port in Kubo, or we have no other use for Kubo RPC in rainbow).
Small nits inline, but fine to proceed I think.
| Value: ":8080", | ||
| &cli.IntFlag{ | ||
| Name: "gateway-port", | ||
| Value: 8080, |
There was a problem hiding this comment.
💭 maybe we should pick a different default port than Kubo and bifrost-gateway, for the sake of local dev's sanity, as I know I will run all three of them this quarter many times at the same time.
| Value: 8080, | |
| Value: 8090, |
There was a problem hiding this comment.
Hmm for the sake of drop-in I wouldn't...
| Value: "127.0.0.1:8081", | ||
| &cli.IntFlag{ | ||
| Name: "api-port", | ||
| Value: 8081, |
There was a problem hiding this comment.
Same here, avoid clash with metrics port of bifrost-gateway.
| Value: 8081, | |
| Value: 8091, |
| refresher *time.Ticker | ||
| } | ||
|
|
||
| func newCachedDNS(refreshInterval time.Duration) *cachedDNS { |
There was a problem hiding this comment.
Normally we would install a local resolver with its own caching in place but it wouldn't be needed in any case with this, iirc?
There was a problem hiding this comment.
yeah, if we want to drop this and just have the OS take care of it that's also totally fine. Leaving it for now though
* add Kubo RPC URL env vars and /api/v0 support via delegation/forwarding * add DNS resolution caching layer * add tracing and metrics * add debugging and metrics endpoints * add Dockerfile * switched cli flags to only expose the port and always run on localhost
Co-authored-by: Marcin Rataj <[email protected]>
aschmahmann
force-pushed
the
feat/deployment-basics
branch
from
ec98f8b
to
0178264
Compare
|
Let's merge and pick up from here with smaller things? |
|
Yep, I'm fine to merge as is and we can discuss some of the other changes later if there's still some contention (e.g. default ports, if we want to test other DHT configurations, etc.). This seems like it should be fine though. Note: it'd be nice to add some more CI testing here 😅, but can do that in a follow up. Someone can hit merge once CI is green (still running for me) |
This has mostly been copied from bifrost-gateway. Main changes are:
delegation/forwarding