Add resource manager support. Follow Kubo. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanjuan
commented
Oct 13, 2023
|
|
||
| func makeResourceManagerConfig(maxMemory uint64, maxFD int, connMgrHighWater int) (limitConfig rcmgr.ConcreteLimitConfig) { | ||
| if maxMemory == 0 { | ||
| maxMemory = uint64((float64(memory.TotalMemory()) * 0.85)) |
There was a problem hiding this comment.
0.85 is the multiplier that current gateways are using for max-memory.
This adds libp2p resource manager support. It follows Kubo's resource manager initialization (copy-pasted mostly), as it seems dealing with a default setup has many pitfalls. Fixes #10
hsanjuan
force-pushed
the
resource-manager
branch
from
011f56e
to
7714145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds libp2p resource manager support. It follows Kubo's resource manager initialization (copy-pasted mostly), as it seems dealing with a default setup has many pitfalls.
Fixes #10