Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integrated nopfs-content blocking to the gateway #22

Merged
merged 6 commits into from
Oct 13, 2023
Merged

Conversation

hsanjuan
Copy link
Contributor

Some things need bubbling/merging, starting with ipfs/boxo#484

This is pending some go.mod bubbling.
setup.go Outdated
Comment on lines 304 to 309
fetcherConfig.PrototypeChooser = dagpb.AddSupportToChooser(func(lnk ipld.Link, lnkCtx ipld.LinkContext) (ipld.NodePrototype, error) {
if tlnkNd, ok := lnkCtx.LinkNode.(schema.TypedLinkNode); ok {
return tlnkNd.LinkTargetNodePrototype(), nil
}
return basicnode.Prototype.Any, nil
})
Copy link
Contributor Author

@hsanjuan hsanjuan Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is... I wish it was more hidden, i.e. something that happens in NewBasicResolver.

@lidel this is indeed the default? https://github.com/ipfs/boxo/blob/main/fetcher/impl/blockservice/fetcher.go#L127

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsanjuan
Copy link
Contributor Author

It ended up pretty simple after ipfs-shipyard/nopfs#21

@hsanjuan hsanjuan marked this pull request as ready for review October 12, 2023 17:27
@hsanjuan hsanjuan linked an issue Oct 13, 2023 that may be closed by this pull request
@hsanjuan
Copy link
Contributor Author

We will need a follow-up to subscribe to lists.... we need to make them append-only first.

@hsanjuan hsanjuan merged commit 858df29 into main Oct 13, 2023
7 checks passed
@hsanjuan hsanjuan deleted the nopfs branch October 13, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce NoPFS
1 participant