feat: compute buffer size ahead of time #23
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation loops over message fields and each field encoder creates a
Uint8Array
which is added to aUint8ArrayList
and stitched together at the end of the process.Other implementations compute the expected length of the serialized message, allocate a buffer that size then have encoders write their data into it at the correct offsets.
This PR makes protons compute the final message buffer size first in the same way.
Thing is, it doesn't seem to make a huge amount of difference to performance.
Before:
After: