fix(gateway): question marks in url.Path when redirecting #9894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
force-pushed
the
issues/9882
branch
3 times, most recently
from
a80ef08
to
dd5004b
Compare
hacdias
changed the title
lidel
changed the title
lidel
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
I've tested this locally with latest version of #9894 and works as expected, but we need to rebase this PR after #9886 is merged, and then switch to the latest revision of boxo.
@hacdias see details in #9913 (review), they apply to this PR as well.
|
This is no longer necessary as #9913 updated to the latest Boxo, which includes ipfs/boxo#313. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9882, fixes ipfs/ipfs-companion#1201.