feat: support line comments in config #10592
Open
+37
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
?? I'm assuming this was a vestige of a prior refactor. Finishes the renaming of the package to match folder structure and semantics.
lidel
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Sounds really useful, but may be time consuming to fix support for this everywhere (hard to estimate the work, right now the entire CI is red).
We've been discussing replacing JSON config with alternative format that supports comments natively, like YAML, perhaps that is more future proof route?
@ipfs/kubo-maintainers thoughts / preferences?
|
I'm for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for commenting out sections of your
.ipfs/configI find myself wanting to comment out sections as I tweak the config. But no strong preference here. Take it or leave it.