feat(libp2p): enable shared TCP listeners #10565
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/libp2p-sharedtcp
branch
from
8cd0e01
to
215ae53
Compare
lidel
reviewed
Oct 30, 2024
| @@ -64,6 +66,10 @@ func Transports(tptConfig config.Transports) interface{} { | |||
| opts.Opts = append(opts.Opts, libp2p.Transport(webrtc.New)) | |||
| } | |||
|
|
|||
| if tcpEnabled || wsEnabled { | |||
| opts.Opts = append(opts.Opts, libp2p.ShareTCPListener()) | |||
There was a problem hiding this comment.
Feels odd we need to do this for TCP, but not for UDP.
Dropped comment in https://github.com/libp2p/go-libp2p/pull/2984/files#r1823606432
aschmahmann
force-pushed
the
feat/libp2p-sharedtcp
branch
2 times, most recently
from
702101e
to
60d8d5c
Compare
aschmahmann
force-pushed
the
feat/libp2p-sharedtcp
branch
from
60d8d5c
to
7833e64
Compare
aschmahmann
force-pushed
the
feat/libp2p-sharedtcp
branch
from
f9c50bd
to
590bed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10560, relies on libp2p/go-libp2p#2984