[WIP] feat: add ability to start js-ipfs nodes #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
requested changes
Nov 11, 2017
package.json
Outdated
| "release": "aegir release -t node", | ||
| "release-minor": "aegir release --type minor -t node", | ||
| "release-major": "aegir release --type major -t node", | ||
| "coverage-publish": "aegir coverage -u" |
There was a problem hiding this comment.
Please make an aegir upgrade be part of a separate PR
There was a problem hiding this comment.
kk, will pull aegir out.
Closed
dryajov
force-pushed
the
feat/support-js
branch
2 times, most recently
from
4d814b1
to
ec8de2a
Compare
dryajov
changed the title
dryajov
changed the title
dryajov
changed the title
|
this depends on ipfs/js-ipfs#1095 now. |
thisconnect
reviewed
Nov 23, 2017
test/spawning-daemons.js
Outdated
| // fails on windows see https://github.com/ipfs/js-ipfs-api/issues/408 | ||
| if (isWindows) { | ||
| return it.skip('uses the correct ipfs-api') | ||
| } |
There was a problem hiding this comment.
This skip has been removed in 381ac1c, you may have to rebase https://github.com/ipfs/js-ipfsd-ctl/network
dryajov
force-pushed
the
feat/support-js
branch
from
ec8de2a
to
e0f7efd
Compare
dryajov
force-pushed
the
feat/support-js
branch
from
e0f7efd
to
593c534
Compare
|
Is this still needed with #176 ? |
|
this is not needed anymore - closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on - ipfs/js-ipfs#1067