This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: WebSocketStar #1090
Merged
feat: WebSocketStar #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related #1088 |
daviddias
reviewed
Nov 27, 2017
| connection: { | ||
| muxer: [Multiplex], | ||
| crypto: [SECIO] | ||
| }, | ||
| discovery: [wstar.discovery] | ||
| discovery: [wstar.discovery, wsstar.discovery] | ||
| } | ||
|
|
||
| if (options.bootstrap) { |
There was a problem hiding this comment.
Following on the comment -- libp2p/js-libp2p#122 (comment) --, this actually should totally work now because websocket-star becomes part of the set of transports supported by default //cc @patrickdet @Beanow
daviddias
approved these changes
Nov 27, 2017
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
License: MIT Signed-off-by: Alan Shaw <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding websocket-star transport