Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help message shows tagged build version #86

Closed
wants to merge 1 commit into from
Closed

Help message shows tagged build version #86

wants to merge 1 commit into from

Conversation

gammazero
Copy link
Contributor

If current commit is not matched by tag, then also show commit.

Fixes issue #30

@gammazero
Help message shows tagged build version
f20cc08 
If current commit is not matched by tag, then also show commit.

Fixes issue #30
@gammazero gammazero mentioned this pull request May 12, 2021
Merged
Stebalien
Stebalien reviewed May 12, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this won't work with our build system (which uses go build FULL_PACKAGE_PATH for plugin reasons...).

@gammazero
Copy link
Contributor Author

Not compatible with build system

@gammazero gammazero closed this May 13, 2021
@gammazero gammazero deleted the chore/help-shows-version-and-commit branch May 13, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gammazero @Stebalien