feat: add sharing statistics on the homepage #1942
Conversation
Jorropo
commented
Jun 6, 2022
Jorropo
commented
Jorropo
force-pushed
the
share-ratio
branch
2 times, most recently
from
520a47b
to
50f39a9
Compare
Jorropo
changed the title
Jorropo
force-pushed
the
share-ratio
branch
4 times, most recently
from
8bed475
to
c33f0e4
Compare
| @@ -10,6 +10,7 @@ | |||
| "countMore": "...and {count} more", | |||
| "StatusConnected": { | |||
| "repoSize": "Hosting {repoSize} of data", | |||
| "shareSize": "Downloaded {downloadedSize} and Shared {sharedSize} ({ratio})", | |||
There was a problem hiding this comment.
I think we should add some indication that this is not since the beginning, but just for the current session. Maybe some surrounding box saying current session?
There was a problem hiding this comment.
I like the idea of a "Since {date}" prefix.
Also, this is a great candidate for #1220
lidel
force-pushed
the
main
branch
4 times, most recently
from
dabaee3
to
7ddf870
Compare
| @@ -10,6 +10,7 @@ | |||
| "countMore": "...and {count} more", | |||
| "StatusConnected": { | |||
| "repoSize": "Hosting {repoSize} of data", | |||
| "shareSize": "Downloaded {downloadedSize} and Shared {sharedSize} ({ratio})", | |||
There was a problem hiding this comment.
I like the idea of a "Since {date}" prefix.
Also, this is a great candidate for #1220
src/bundles/bitswap-stats.js
Outdated
| const bundle = createAsyncResourceBundle({ | ||
| name: 'bitswapStats', | ||
| getPromise: async ({ getIpfs }) => { | ||
| const rawData = await getIpfs().stats.bitswap() |
There was a problem hiding this comment.
What happens if this function throws?
Also, prefer const { dataReceived, dataSent } = await getIpfs().stats.bitswap()
There was a problem hiding this comment.
What happens if this function throws?
I have no idea, wtf is javascript anyway ?
(I guess the ressources are never initialised which isn't that bad ?)
| bundle.selectDownloadedSize = createSelector( | ||
| 'selectBitswapStats', | ||
| (bitswapStats) => { | ||
| if (bitswapStats && bitswapStats.downloadedSize) { |
There was a problem hiding this comment.
eslint should be yelling here about using optional chaining instead, e.g. bitswapStats?.downloadedSize. Also, most of our eslint rules prefer explicit boolean checks, so either
Boolean(bitswapStats?.downloadedSize)orbitswapStats?.downloadedSize != null
You may want to check your editor settings.
| bundle.selectSharedSize = createSelector( | ||
| 'selectBitswapStats', | ||
| (bitswapStats) => { | ||
| console.log(bitswapStats) |
There was a problem hiding this comment.
do we still need this? If so, prefer logger.debug or similar. If not, remove please :)
| 'selectBitswapStats', | ||
| (bitswapStats) => { | ||
| console.log(bitswapStats) | ||
| if (bitswapStats && bitswapStats.sharedSize) { |
There was a problem hiding this comment.
Boolean(bitswapStats?.sharedSize)orbitswapStats?.sharedSize != null
| const humanRepoSize = humanSize(repoSize || 0) | ||
| downloadedSize = downloadedSize || 0 |
There was a problem hiding this comment.
nit: we should prefer the null coalescence operator (??) instead of the OR operator (||) for default values if possible. I assume we also want to make sure downloadedSize is a number? Number(downloadedSize ?? 0)
ditto for other vars here.
|
assigning to Dan to push past the finish line |
