WIP: Store multibase prefix with CID #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
So, CIDs always use a multibase in text. The spec has always been a bit unclear on this subject but I'd be strongly against any attempt to carry the multibase along with a CID. That mixes data with representation a bit too much for my tastes. Ideally, on the command line, we'd:
|
|
@Stebalien this doesn't need to go in right away. Can we hold off on making a quick judgement. I will write a full proposal (with several alternatives) on how to handle multibases later today. |
kevina
changed the title
|
See ipfs/kubo#5349 solution 2 for the motivation for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CID spec defines the multibase as part of the CID, yet we do not store it anywhere.
This fixes that, It also creates a variable to change the default base for CIDv1.
This should make preserving the base of a CID a lot less painful for command like
ipfs resolveandipfs pin addor any command that takes a CID from the user.Simplifier version of #64.