Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: percent-encoded filename and _redirects with If-None-Match on DNSLink #160

Merged
merged 3 commits into from
Sep 19, 2023
Merged

test: percent-encoded filename and _redirects with If-None-Match on DNSLink #160

merged 3 commits into from
Sep 19, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Sep 8, 2023 •
edited
Loading

@hacdias hacdias self-assigned this Sep 8, 2023
@hacdias hacdias changed the title Few tests Add a few missing tests Sep 8, 2023
@hacdias
Copy link
Member Author

hacdias commented Sep 8, 2023

@laurentsenta I'm not sure what i did wrong in b88910b but the DNSLink tests are not working and just getting no such host.

@laurentsenta
Copy link
Contributor

laurentsenta commented Sep 11, 2023 •
edited
Loading

@hacdias Use helpers.UnwrapSubdomainTests(t, tests):

gateway-conformance/tests/redirects_file_test.go

Line 279 in bdeb1a9

RunWithSpecs(t, helpers.UnwrapSubdomainTests(t, tests), specs.DNSLinkGateway, specs.RedirectsFile)

It'll turn the queries into different subdomain tests with proxying and all.

@hacdias hacdias changed the title Add a few missing tests Tests for content paths with percent-encoded filename and _redirects with If-None-Match Sep 11, 2023
@hacdias
Copy link
Member Author

hacdias commented Sep 11, 2023

Thanks @laurentsenta. It works now.

@lidel this is now complete. I won't be working this week, so feel free to take it over and merge it.

@hacdias hacdias marked this pull request as ready for review September 11, 2023 09:44
@github-actions
Copy link
Contributor

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1893 11 0 0

@github-actions
Copy link
Contributor

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1893 0 0 0

@laurentsenta
Copy link
Contributor

@lidel @hacdias I'm going to trigger a release today, should we merge this?

@lidel lidel changed the title Tests for content paths with percent-encoded filename and _redirects with If-None-Match test: percent-encoded filename and _redirects with If-None-Match on DNSLink Sep 18, 2023
lidel
lidel approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hacdias @laurentsenta fine to merge and include in release, but if you miss it also ok (as these are not as critical for Rhea/Saturn as range requests).

tests/redirects_file_test.go Show resolved Hide resolved
@laurentsenta laurentsenta merged commit 4dc579c into main Sep 19, 2023
11 of 13 checks passed
@laurentsenta
Copy link
Contributor

Thanks for the contributions and reviews 🙏

@laurentsenta laurentsenta deleted the few-tests branch September 19, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@laurentsenta laurentsenta Awaiting requested review from laurentsenta

Assignees

@hacdias hacdias

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
3 participants
@hacdias @laurentsenta @lidel