refactor: multi range request considers servers that do not return multi range #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
hacdias
commented
Jul 26, 2023
hacdias
force-pushed
the
multirequest-as-per-http-standards
branch
from
cb7fa3d
to
26922e9
Compare
|
2023-07-27 conversation: this is connected to the backpressure work. This will get merged after @lidel takes a look. |
…answer to multiple ranges
hacdias
force-pushed
the
multirequest-as-per-http-standards
branch
from
c029dbc
to
517e9e3
Compare
|
@laurentsenta can we get this released to unblock work on ipfs/boxo#369? We want to run the new tests in Boxo and Kubo. |
3 tasks
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the multi range request such that it counts for servers that are not able to reply with a multi range. When the client asks for a range request 3 things might happen:
multipart/byterangesas Content-Type. Includes both ranges.Content-Typeof the actual data and theContent-Rangeheader with the first range. Body has first range body.Content-Typeof actual data, noContent-Range. Body has full file.https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests