Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitswap(client/messageque): expose donthavetimeout config #703

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Wondertan
Copy link
Member

Closes #701

@Wondertan Wondertan requested a review from a team as a code owner October 24, 2024 03:13
@Wondertan Wondertan changed the title expose donthavetimeout config bitswap(client/messageque): expose donthavetimeout config Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.33%. Comparing base (392493d) to head (d04bd72).

Files with missing lines Patch % Lines
bitswap/client/client.go 20.00% 4 Missing ⚠️
...client/internal/messagequeue/donthavetimeoutmgr.go 94.44% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   60.35%   60.33%   -0.03%     
==========================================
  Files         243      243              
  Lines       31038    31051      +13     
==========================================
  Hits        18734    18734              
- Misses      10637    10648      +11     
- Partials     1667     1669       +2     
Files with missing lines Coverage Δ
...tswap/client/internal/messagequeue/messagequeue.go 83.53% <100.00%> (-1.39%) ⬇️
...client/internal/messagequeue/donthavetimeoutmgr.go 95.39% <94.44%> (+2.12%) ⬆️
bitswap/client/client.go 86.74% <20.00%> (-1.34%) ⬇️

... and 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitswap(messagequeue): Expose DONT_HAVE timeout knobs
1 participant