-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move providing responsabilities from bitswap to blockservice #677
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 60.36% 60.17% -0.20%
==========================================
Files 243 244 +1
Lines 30953 30867 -86
==========================================
- Hits 18684 18573 -111
- Misses 10612 10626 +14
- Partials 1657 1668 +11
|
Needs kubo PR to test |
Reviewing this and probably merging into #641 ... |
ses := grabSessionFromContext(ctx, bs) | ||
if ses != nil { | ||
return ses | ||
} | ||
|
||
return newSession(ctx, bs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why session-grabbing from context is removed... I remember old discussions about embedding sessions in contexts etc. but not sure if used...
Replaces #534 by @Jorropo which was outdated enough to make merging difficult.