-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider: prioritize roots and introduce NewPrioritizedProvider #595
Conversation
437a27b
to
572dc2b
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #595 +/- ##
==========================================
- Coverage 59.78% 59.77% -0.01%
==========================================
Files 232 232
Lines 28139 28186 +47
==========================================
+ Hits 16822 16848 +26
- Misses 9840 9862 +22
+ Partials 1477 1476 -1
|
@aschmahmann what do you think? I can replace the map with a bloom filter. That can probably be better memory wise depending on how streams we're using. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can ship this if we limit CID map to items from the first-pass (details inline).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took it for a spin in ipfs/kubo#10376 and seem to work as expected.
42b4e9a
to
558d9c7
Compare
558d9c7
to
eaa2e39
Compare
See ipfs/kubo#10376.