Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice: add compiletime guard for BoundedBlockService on the blockservice struct #555

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 15, 2024

No description provided.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff4f785) 65.52% compared to head (4d08813) 65.54%.

Impacted file tree graph

@@                                   Coverage Diff                                   @@
##           01-15-blockservice_don_t_store_allowlist_in_Session     #555      +/-   ##
=======================================================================================
+ Coverage                                                65.52%   65.54%   +0.02%     
=======================================================================================
  Files                                                      207      207              
  Lines                                                    25622    25622              
=======================================================================================
+ Hits                                                     16789    16795       +6     
+ Misses                                                    7355     7349       -6     
  Partials                                                  1478     1478              
Files Coverage Δ
blockservice/blockservice.go 75.25% <ø> (ø)

... and 11 files with indirect coverage changes

Copy link
Contributor Author

Jorropo commented Jan 15, 2024

Merge activity

  • Jan 15, 2:53 AM: @Jorropo started a stack merge that includes this pull request via Graphite.
  • Jan 15, 2:56 AM: Graphite rebased this pull request as part of a merge.
  • Jan 15, 2:57 AM: @Jorropo merged this pull request with Graphite.

@Jorropo Jorropo changed the base branch from 01-15-blockservice_don_t_store_allowlist_in_Session to main January 15, 2024 07:54
@Jorropo Jorropo force-pushed the 01-15-blockservice_add_compiletime_guard_for_BoundedBlockService_on_the_blockservice_struct branch from 4d08813 to 98c3890 Compare January 15, 2024 07:55
@Jorropo Jorropo merged commit c7f33e6 into main Jan 15, 2024
11 checks passed
@Jorropo Jorropo deleted the 01-15-blockservice_add_compiletime_guard_for_BoundedBlockService_on_the_blockservice_struct branch January 15, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant