-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove provider query manager #536
base: remove-content-routing-from-bitswap-network
Are you sure you want to change the base?
Remove provider query manager #536
Conversation
Codecov ReportAttention:
@@ Coverage Diff @@
## remove-content-routing-from-bitswap-network #536 +/- ##
==============================================================================
Coverage ? 65.31%
==============================================================================
Files ? 206
Lines ? 25244
Branches ? 0
==============================================================================
Hits ? 16488
Misses ? 7281
Partials ? 1475
|
efaeefb
to
3a493b8
Compare
Keeps in sync with: - ipfs/boxo#534 - ipfs/boxo#535 - ipfs/boxo#536
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1347809
to
28f6549
Compare
3a493b8
to
1fe051b
Compare
if span.IsRecording() { | ||
span.SetAttributes(attribute.Stringer("cid", c)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this be done directly? AFAIK, it won't call .String
unless it's indeed recording. I think it could indeed be more problematic if directly passed as a string and needed to encode it every time. But here it seems fine. Is there another reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It literally always call .String
instantly:
https://github.com/open-telemetry/opentelemetry-go/blob/98b32a6c3a87fbee5d34c063b9096f416b250897/attribute/kv.go#L85
// Stringer creates a new key-value pair with a passed name and a string
// value generated by the passed Stringer interface.
func Stringer(k string, v fmt.Stringer) KeyValue {
return Key(k).String(v.String())
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as on the previous stack, it looks like it does what it says, just a comment inline
28f6549
to
301d5b5
Compare
1fe051b
to
bed8453
Compare
301d5b5
to
d414841
Compare
bed8453
to
15661e4
Compare
d414841
to
5eb2dbc
Compare
15661e4
to
f3d731b
Compare
5eb2dbc
to
0cd80af
Compare
f3d731b
to
1c8b6c9
Compare
0cd80af
to
6740401
Compare
1c8b6c9
to
5104983
Compare
Closes: #172 See #172 (comment) too. providerQueryManager took care of: - Deduping multiple sessions doing find providers for the same CID. - limiting global find providers. None of which we care: - This is rare, if this happens it's fine to run the same query twice. If we care then we should make a deduping content router so we can inject it anywhere a content router is needed. - It's fine to allow one concurrent find peer per session. No need to limit this at 6 globally after that, it's a great way to stall nodes doing many queries.
6740401
to
2dbd42a
Compare
5104983
to
2e813d8
Compare
Keeps in sync with: - ipfs/boxo#578 - ipfs/boxo#534 - ipfs/boxo#535 - ipfs/boxo#536
Based on #535