Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAG Doc update for LACP #406

Merged
merged 4 commits into from
Feb 12, 2024
Merged

LAG Doc update for LACP #406

merged 4 commits into from
Feb 12, 2024

Conversation

aashishkuma
Copy link
Collaborator

This PR updates the LAG readme for the added support of LACP along with the active-backup mode.

@dandaly
Copy link
Contributor

dandaly commented Feb 8, 2024

Can you add to the documentation that active-active can be supported with LACP?

Copy link
Collaborator

@nupuruttarwar nupuruttarwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix markdown lint errors before merging

Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as Nupur. Markdown lint errors need to be fixed. Rest LGTM

Copy link
Contributor

@ffoulkes ffoulkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the indicated changes.

docs/apps/lnw/es2k/es2k-linux-networking-lag.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking-lag.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ffoulkes ffoulkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the indicated changes before merging.

This commit fails the P4CP lint checks / markdownlint checker. (See the list of checks below. Click on Details to see the list of errors.) GitHub will block the merge until you fix the problem.

Note that the checker reports three issues, not two. You need to remove one or more trailing blanks (space characters at the end of the line) from the specified line.

@aashishkuma aashishkuma merged commit 506bf08 into main Feb 12, 2024
9 checks passed
@ffoulkes ffoulkes deleted the LACP_Documentation branch March 13, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants