"bf_" name change for P4CP #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoulkes
requested changes
Feb 6, 2024
There was a problem hiding this comment.
There's a right way and a wrong way to make changes in the public interface between components.
This is categorically the wrong way. It is irresponsible, unprofessional, and disruptive, and it seriously compromises the quality and maintainability of the software.
We need to push back on this for the good of the project.
Signed-off-by: Kumar, Aashish <[email protected]>
ffoulkes
approved these changes
Feb 8, 2024
aashishkuma
requested review from
nupuruttarwar,
n-sandeep,
vsureshkumarp and
5abeel
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This underlying P4SDE for ES2K target is renaming bf_swtichd to ipu_p4d.
The P4SDE changes are:
https://github.com/intel-innersource/networking.ethernet.acceleration.vswitch.p4-sde.p4-driver/tree/rename-bf
This PR contains the changes required in the networking recipe to build ES2K target with the underlying P4SDE change.
Note:
There are changes expected in the stratum and krnlmon module as well and the pull requests will be raised separately for both of these modules.