-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with ovs sidecar and minor issue with p4rt-ctl #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues fixed: - Tunnel termination table is called twice which results in multiple failure logs. Modify code to call only once. - SET_TUNNEL_V6 param was not properly setting all IPv6 bits. - read either GetL2ToTunnelV6TableEntry only if entry is not found in GetL2ToTunnelV4TableEntry. This is causing multiple unwanted reads and creating lot of failure logs Signed-off-by: Sandeep N <[email protected]>
n-sandeep
requested review from
ffoulkes,
nupuruttarwar,
vsureshkumarp and
5abeel
as code owners
February 2, 2024 17:44
n-sandeep
force-pushed
the
fix-ovs-sidecar-issues
branch
from
February 2, 2024 17:45
8548a7d
to
9fc5062
Compare
5abeel
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. Rest LGTM
ffoulkes
reviewed
Feb 2, 2024
n-sandeep
force-pushed
the
fix-ovs-sidecar-issues
branch
from
February 9, 2024 11:37
abc3c56
to
259fef6
Compare
satish153
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues fixed: