Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with ovs sidecar and minor issue with p4rt-ctl #403

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

n-sandeep
Copy link
Contributor

Issues fixed:

  • Tunnel termination table is called twice which results in multiple failure logs. Modify code to call only once.
  • SET_TUNNEL_V6 param was not properly setting all IPv6 bits.
  • read either GetL2ToTunnelV6TableEntry only if entry is not found in GetL2ToTunnelV4TableEntry. This is causing multiple unwanted reads and creating lot of failure logs

Issues fixed:
  - Tunnel termination table is called twice which results in multiple
    failure logs. Modify code to call only once.
  - SET_TUNNEL_V6 param was not properly setting all IPv6 bits.
  - read either GetL2ToTunnelV6TableEntry only if entry is not found in
    GetL2ToTunnelV4TableEntry. This is causing multiple unwanted reads
    and creating lot of failure logs

Signed-off-by: Sandeep N <[email protected]>
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Rest LGTM

ovs-p4rt/ovs_p4rt.cc Outdated Show resolved Hide resolved
ovs-p4rt/ovs_p4rt.cc Outdated Show resolved Hide resolved
ovs-p4rt/ovs_p4rt.cc Show resolved Hide resolved
ovs-p4rt/ovs_p4rt.cc Outdated Show resolved Hide resolved
ovs-p4rt/ovs_p4rt.cc Outdated Show resolved Hide resolved
ovs-p4rt/ovs_p4rt.cc Show resolved Hide resolved
ovs-p4rt/ovs_p4rt.cc Show resolved Hide resolved
ovs-p4rt/ovs_p4rt.cc Show resolved Hide resolved
ovs-p4rt/ovs_p4rt.cc Outdated Show resolved Hide resolved
Copy link
Collaborator

@satish153 satish153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n-sandeep n-sandeep merged commit 6ed3a91 into main Feb 9, 2024
9 checks passed
@n-sandeep n-sandeep deleted the fix-ovs-sidecar-issues branch February 9, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants