-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switchlink header file cleanup #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoulkes
requested review from
nupuruttarwar,
n-sandeep and
vsureshkumarp
as code owners
March 4, 2024 04:36
ffoulkes
changed the title
Switchlink housekeeping
Switchlink housekeeping and refactoring
Mar 5, 2024
ffoulkes
changed the title
Switchlink housekeeping and refactoring
Switchlink header file cleanup
Mar 5, 2024
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
- Deleted unused definition of switchlink_get_nl_sock(). - Deleted unused definition of switchlink_entry_type. - Made switchlink_nhop_using_by a simple enum instead of a typedef. Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
- Deleted switchlink_neigh.h and switchlink_route.h, which are no longer used. They duplicate definitions in switchlink_int.h. Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
force-pushed
the
switchlink-refactor
branch
from
March 6, 2024 17:30
7600cc1
to
18ef633
Compare
nupuruttarwar
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5abeel
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes emerged from an effort to implement Bazel support for the Kernel Monitor.
I know it looks like a lot, but I think you'll see a small number of patterns being repeated across the files. I rated it medium because of the number of files changed. In truth, it's probably a minor effort (15 minutes or less).
switchlink_handle.h
toswitchlink_handlers.h
, to make it clear that this file defines interfaces to switchlink handlers, notswitchlink_handle_t
. (readability)switchlink_link.h
toswitchlink_link_types.h
, to make it clear that this file defines switchlink data types, and is not the header file forswitchlink_link.c
. (readability)switchlink_globals.c
to a newswitchlink_globals.h
header file. (separation of concerns; cohesiveness)SWITCHLINK_LOG_XXX
andg_log_level
definitions. (dead code)switchlink_get_nl_sock()
. (dead code)switchlink_entry_type
. (dead code)switchlink_nhop_using_by
a simple enum instead of a typedef. (reducing complexity and coupling.)