Fix issues with LACP and nexthop LAG action #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues fixed are: Populate tx_lag_table, modify exact t ternary match for this table. Populate RIF tables Populate correct dmac_high and dmac_low fields correctly Handle LACP bond interface delete and re-add Signed-off-by: Sandeep N <[email protected]>
n-sandeep
requested review from
ffoulkes,
5abeel and
vsureshkumarp
as code owners
5abeel
approved these changes
Jun 20, 2024
| @@ -190,7 +190,7 @@ switch_status_t switch_pd_tx_lag_table_entry(switch_device_t device, | |||
| } | |||
|
|
|||
| status = tdi_key_field_set_value_and_mask(key_hdl, field_id_hash, | |||
| lag_list + port_count, 0x3); | |||
| lag_list + port_count, 0x7); | |||
There was a problem hiding this comment.
He's widening a two-bit mask to three bits, which appears to be the width of the field in the P4 program.
ffoulkes
approved these changes
Jun 20, 2024
| @@ -190,7 +190,7 @@ switch_status_t switch_pd_tx_lag_table_entry(switch_device_t device, | |||
| } | |||
|
|
|||
| status = tdi_key_field_set_value_and_mask(key_hdl, field_id_hash, | |||
| lag_list + port_count, 0x3); | |||
| lag_list + port_count, 0x7); | |||
There was a problem hiding this comment.
He's widening a two-bit mask to three bits, which appears to be the width of the field in the P4 program.
| @@ -343,6 +367,17 @@ void switchlink_delete_lag(uint32_t ifindex) { | |||
| return; | |||
| } | |||
|
|
|||
| /* Delete LAG members for an LACP */ | |||
| if (lag_intf.bond_mode == SWITCHLINK_BOND_MODE_LACP) { | |||
| uint32_t member_if_index = 0; | |||
There was a problem hiding this comment.
The loop might be clearer in the following form:
for (;;) {
uint32_t member_if_index =
switchlink_db_delete_lacp_member(lag_intf.lag_h);
if (member_if_index == -1) break;
switchlink_delete_lag_member(member_if_index);
}| switchlink_db_lag_member_obj_t* obj = node->data; | ||
| krnlmon_assert(obj != NULL); | ||
| node = node->next; | ||
| if ((obj->lag_member_info.lag_h == lag_h)) { |
There was a problem hiding this comment.
Suggested change
| if ((obj->lag_member_info.lag_h == lag_h)) { | |
| if (obj->lag_member_info.lag_h == lag_h) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues fixed are: