Cob behaviour #321
Cob behaviour #321
Conversation
Sync changes
…into indigo_dev
…into indigo_dev
| @@ -17,8 +17,10 @@ | |||
|
|
|||
| <run_depend>camera1394</run_depend> | |||
| <run_depend>canopen_motor_node</run_depend> | |||
| <run_depend>cob_android_script_server</run_depend> | |||
There was a problem hiding this comment.
cob_android is still not released!
| <param name="/sound_controller/mode" value="cepstral" /> | ||
| <include file="$(find cob_bringup)/drivers/sound.launch" /> | ||
|
|
||
| <include file="$(find cob_bringup)/drivers/mimic.launch" /> |
There was a problem hiding this comment.
can mimic now be launched from the current user?
is logging into the head display not required anymore?
There was a problem hiding this comment.
It is fixed, now you can launch mimic with all the users.
|
I think this PR needs to be cleaned up (preferably squashed) after the remaining remarks have been addressed....it currently contains quite a lot of changes not related to |
|
This PR cannot be merged. Please update with latest ipa320 indigo_dev. |
|
I can close this pull request, and open a new one with the actual robot working version. We have also still the teleop problem , until we have a new teleop node we should not merge this pull request and the cob4-4 PR #307. My suggestion is wait for teleop node, addapt the parameters and launch files , merge with ipa320, resolving merge conflicts, and test it on the robots. And then open pull request from ipa-cob4-X accounts. |
|
Keep this one open until there actually is a superseding PR! Features from this PR that are not related to |
| @@ -111,7 +117,7 @@ | |||
| <arg name="robot" value="$(arg robot)"/> | |||
| <arg name="component_name" value="sensorring"/> | |||
| </include> | |||
|
|
|||
|
please make sure the changes within |
|
LGTM |
Please, don't merge this pull request before cob_android is "released"