Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sugestion for a new grammar for the message specifications #197

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ipa-nhg
Copy link
Member

@ipa-nhg ipa-nhg commented May 16, 2023

These changes are from @ipa-rwu
This PR include the remaining commits from #194
‼️ Code has to be re-generated before merge ‼️

This suggestion requires a major discussion. Initially, the idea was to keep the .msg format for the definition of the specifications, for example:

std_msgs:
 specs:
  msg: ColorRGBA
    message:
       float32 r
       float32 g
       float32 b
       float32 a
std_srvs:
 specs:
  srv: Trigger
    response:
       bool sucess
       string message

This approach will significantly lower the entry barrier for the ROS community. As the original code is:

std_msgs/ColorRGBA.msg

float32 r
float32 g
float32 b
float32 a

std_srvs/Trigger.srv

---
bool success   # indicate successful run of triggered service
string message # informational, e.g. for error messages

With this PR you are proposing:

std_msgs:
  specs:
    - msg: ColorRGBA
      message:
        r: float32
        g: float32
        b: float32
        a: float32
std_srvs:
  specs:
    - srv: Trigger
      request:
      response:
        success: bool
        "message": string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants