Fix Unlock Syntactic Validation #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A reference index must be Max Inputs Count - 1, because it otherwise could be a self reference (which is not allowed in the unlocks validation, but not point in allowing that for a reference unlock then in the first place)
lzpap
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
LGTM!
@Thoralf-M could you DRI the change in iota.go and hornet respectively? The impact is minimal as all what changes is the tx becoming syntactically invalid rather then semantically invalid.
|
@lzpap there it's already correct or not?https://github.com/iotaledger/iota.go/blob/d9965e47e73db490acca2c1ede03d66965e9c1db/utxo_input.go#L15 |
|
The link above was for Chrysalis, actually let's keep it as is and change only in 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reference index must be <
Max Inputs Count - 1, because it otherwise could be a self reference, which is not allowed in the unlocks semantic validation. So no point in allowing that in the syntactic validation of an unlock then in the first place