Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create claimDelegationRewardsPopup #8235

Merged
merged 38 commits into from
Apr 3, 2024
Merged

feat: create claimDelegationRewardsPopup #8235

merged 38 commits into from
Apr 3, 2024

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #8196

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

cpl121 and others added 23 commits March 6, 2024 15:16
@cpl121
feat: implement logic to allow tx or not based on mana cost for the X…
ff44d76 
… slots
@marc2332
fixes and clean up
46aa693
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
357cedd
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
0c25980
@marc2332
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
24899df
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
37dfe97
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
f327b18
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
9f959e7
@cpl121
Merge branches 'feat/add-buffer-to-show-mana-cost' and 'develop-iota2…
5b3ce04 
….0' of github.com:iotaledger/firefly into feat/add-buffer-to-show-mana-cost
@cpl121
feat: add mana cost to mint, burn, send and implicitTransition
719d742
@cpl121
feat: improvements in mana box component
ba4c3dd
@cpl121
feat: add mana cost to claim activity
c106747
@cpl121
feat: add mana cost to create delegation
331bddd
@cpl121
feat: add mana cost to claim shimmer
e46319b
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
39bd5f9
@cpl121
Merge branch 'feat/add-buffer-to-show-mana-cost' into feat/add-mana-c…
efb799c 
…ost-everywhere
@cpl121
fixes
f8e1472
@cpl121
Merge branches 'feat/add-mana-cost-everywhere' and 'feat/add-buffer-t…
b40de0c 
…o-show-mana-cost' of github.com:iotaledger/firefly into feat/add-mana-cost-everywhere
@cpl121
Merge branches 'feat/add-mana-cost-everywhere' and 'develop-iota2.0' …
9a428ba 
…of github.com:iotaledger/firefly into feat/add-mana-cost-everywhere
@cpl121
fix: add conditional chaining
d837904
@cpl121
Merge branches 'feat/add-mana-cost-everywhere' and 'develop-iota2.0' …
1e7af29 
…of github.com:iotaledger/firefly into feat/add-mana-cost-everywhere
@evavirseda
feat: create claimDelegationRewardPopup
4afb2ce
@begonaalvarezd
Merge branch 'develop-iota2.0' into feat/add-mana-cost-everywhere
0f34d7c
@evavirseda evavirseda linked an issue Mar 21, 2024 that may be closed by this pull request
[Task]: create dedicated popup to claim a delegation reward #8196
Closed
@evavirseda evavirseda marked this pull request as ready for review March 21, 2024 11:35
@evavirseda evavirseda requested a review from cpl121 March 21, 2024 11:35
Base automatically changed from feat/add-mana-cost-everywhere to develop-iota2.0 March 21, 2024 16:51
@evavirseda
Merge branch 'develop-iota2.0' into feat/create-claim-delegation.rewa…
d3281f7 
…rd-popup

packages/desktop/components/popups/BurnNativeTokensConfirmationPopup.svelte
packages/desktop/components/popups/MintNativeTokenConfirmationPopup.svelte
packages/desktop/components/popups/MintNftConfirmationPopup.svelte
packages/desktop/components/popups/send/SendConfirmationPopup.svelte
packages/desktop/views/dashboard/wallet/views/implicit-account-creation-multistep/FundConfirmationView.svelte
packages/desktop/views/onboarding/views/restore-profile/views/ClaimFinderView.svelte
cpl121
cpl121 requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 1 comment.
I do a commit with some errors not related to this PR, but related with delegation

packages/desktop/components/popups/claimDelegationRewardsPopup.svelte Outdated Show resolved Hide resolved
@evavirseda evavirseda requested a review from cpl121 March 22, 2024 12:34
@evavirseda evavirseda requested a review from cpl121 March 25, 2024 08:53
cpl121
cpl121 reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but can't be tested well. Let's see if tomorrow there is more luck and we can create and claim delegation outputs 🤞🏼

@cpl121 cpl121 merged commit 79ed033 into develop-iota2.0 Apr 3, 2024
3 of 4 checks passed
@cpl121 cpl121 deleted the feat/create-claim-delegation.reward-popup branch April 3, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@cpl121 cpl121 cpl121 approved these changes

@marc2332 marc2332 Awaiting requested review from marc2332

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: create dedicated popup to claim a delegation reward
4 participants
@evavirseda @begonaalvarezd @cpl121 @marc2332