feat: claim rewards from delegation outputs (#8136)

* feat: claim rewards from delegation outputs * feat: update logic to claim delegation rewards * fix: improve error to handle onClick button action * feat: add a TODO comment with new task to fix the claim rewards * fix: use computeAccountId to generate delegationId * feat: add computeDelegationId * Update packages/shared/lib/core/api/interfaces/api.interface.ts Co-authored-by: Marc Espin <[email protected]> * feat: improve delegationId and add the rewards con confirmation popup * feat: add Mana to description of claimDelegationRewards --------- Co-authored-by: Marc Espin <[email protected]>
iotaledger · Mar 12, 2024 · 8abbc92 · 8abbc92
1 parent 6887d69
commit 8abbc92
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 10 deletions.
diff --git a/packages/desktop/views/dashboard/delegation/Delegation.svelte b/packages/desktop/views/dashboard/delegation/Delegation.svelte
@@ -13,20 +13,24 @@
  ButtonSize,
  CopyableBox,
  BoxedIconWithText,
+ TextHintVariant,
  } from '@ui'
- import { activeProfile } from '@core/profile'
+ import { activeProfile, checkActiveProfileAuth } from '@core/profile'
  import {
  formatTokenAmountBestMatch,
  AddressConverter,
+ getDefaultTransactionOptions,
  selectedWalletAssets,
+ EMPTY_HEX_ID,
  getOutputRewards,
  getCommitteeInfo,
  } from '@core/wallet'
  import { truncateString } from '@core/utils'
  import { Icon as IconEnum } from '@auxiliary/icon'
- import { OutputType, DelegationOutput, OutputData } from '@iota/sdk/out/types'
- import { PopupId, openPopup } from '@auxiliary/popup'
+ import { OutputType, DelegationOutput, OutputData, DelegationId } from '@iota/sdk/out/types'
+ import { PopupId, closePopup, openPopup } from '@auxiliary/popup'
  import features from '@features/features'
+ import { api } from '@core/api'
  import { DEFAULT_MANA } from '@core/network'
 
  let delegationData: IDelegationTable[] = []
@@ -71,13 +75,18 @@
  const delegationOutput = output.output as DelegationOutput
  // Until the first epoch in which it was delegated ends, no rewards are obtained
  const epochsDelegating = currentEpoch - delegationOutput.startEpoch
+ let delegationId: DelegationId = delegationOutput.delegationId
+ if (delegationId === EMPTY_HEX_ID) {
+ delegationId = api.computeDelegationId(output.outputId)
+ }
+ const rewards = await getOutputRewards(output.outputId)
  return {
- [Header.DelegationId]: delegationOutput.delegationId,
+ [Header.DelegationId]: delegationId,
  [Header.DelegatedFunds]: Number(delegationOutput.delegatedAmount),
- [Header.Rewards]: await getOutputRewards(output.outputId),
+ [Header.Rewards]: rewards,
  [Header.Epochs]: epochsDelegating > 0 ? epochsDelegating : 0,
  [Header.DelegatedAddress]: AddressConverter.addressToBech32(delegationOutput.validatorAddress),
- [Header.Action]: handleClaimRewards,
+ [Header.Action]: () => handleClaimRewards(delegationId, rewards),
  }
  }) || []
  delegationData = await Promise.all(result)
@@ -94,8 +103,27 @@
  })
  }
 
- function handleClaimRewards(): void {
- // TODO: add logic to claim reward
+ function handleClaimRewards(delegationId: string, rewards: number): void {
+ openPopup({
+ id: PopupId.Confirmation,
+ props: {
+ title: localize('popups.claimDelegationRewards.title'),
+ description: localize('popups.claimDelegationRewards.description', {
+ values: { rewards, delegationId },
+ }),
+ confirmText: localize('popups.claimDelegationRewards.confirmButton'),
+ variant: TextHintVariant.Success,
+ onConfirm: async () => {
+ await checkActiveProfileAuth(
+ async () => {
+ await $selectedWallet.burn({ delegations: [delegationId] }, getDefaultTransactionOptions())
+ closePopup()
+ },
+ { stronghold: true }
+ )
+ },
+ },
+ })
  }
 
  function renderCellValue(value: any, header: string): { component: any; props: any; text?: string } {
@@ -160,7 +188,7 @@
  return {
  component: Button,
  props: { size: ButtonSize.Small, onClick: value, outline: true },
- text: 'Claim Rewards',
+ text: localize('popups.claimDelegationRewards.title'),
  }
  default:
  return {

diff --git a/packages/shared/lib/core/api/interfaces/api.interface.ts b/packages/shared/lib/core/api/interfaces/api.interface.ts
@@ -12,6 +12,7 @@ import {
  Bech32Address,
  ProtocolParameters,
  DecayedMana,
+ DelegationId,
 } from '@iota/sdk/out/types'
 import { IWallet } from '@core/profile/interfaces'
 
@@ -45,5 +46,6 @@ export interface IApi {
  computeFoundryId(accountId: AccountId, serialNumber: number, tokenSchemeType: number): FoundryId
  computeNftId(outputId: string): NftId
  computeOutputId(id: TransactionId, index: number): OutputId
+ computeDelegationId(outputId: OutputId): DelegationId
  outputHexBytes(output: Output): HexEncodedString
 }
diff --git a/packages/shared/lib/core/wallet/utils/getDefaultTransactionOptions.ts b/packages/shared/lib/core/wallet/utils/getDefaultTransactionOptions.ts
@@ -11,6 +11,5 @@ export function getDefaultTransactionOptions(
  value: new AccountAddress(accountId),
  },
  allowMicroAmount: true,
- allowAllottingFromAccountMana: true,
  }
 }
diff --git a/packages/shared/locales/en.json b/packages/shared/locales/en.json
@@ -1262,6 +1262,11 @@
  "title": "Account Address",
  "description": "Account Address for the validator"
  } 
+ },
+ "claimDelegationRewards": {
+ "title": "Claim Rewards",
+ "description": "Claim all the rewards, {rewards} Mana, of this delegation output {delegationId}",
+ "confirmButton": "Claim"
  }
  },
  "actions": {