fix: crash accounts if not selected output (#8204)

* fix: crash-accounts-if-not-selected-output * feat: add a message if there isnt info of accounts * feat: improve emptyAccounts text * fix: emptyAccounts text --------- Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
iotaledger · Mar 19, 2024 · 0db5de7 · 0db5de7
1 parent c5a0f34
commit 0db5de7
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 14 deletions.
diff --git a/packages/desktop/views/dashboard/account-management/AccountManagement.svelte b/packages/desktop/views/dashboard/account-management/AccountManagement.svelte
@@ -4,14 +4,16 @@
  import { AccountManagementDetails, AccountManagementList } from '@components'
  import { AccountOutput, OutputData } from '@iota/sdk/out/types'
  import { isAccountOutput, isImplicitAccountOutput } from '@core/wallet'
+ import { Text } from '@ui'
+ import { localize } from '@core/i18n'
 
  $: allAccountOutputs =
  $selectedWallet?.walletUnspentOutputs?.filter(
  (output) => isAccountOutput(output) || isImplicitAccountOutput(output)
  ) || []
 
  let selectedOutput =
- $selectedWallet.walletUnspentOutputs.find(
+ $selectedWallet?.walletUnspentOutputs?.find(
  (output) => (output.output as AccountOutput)?.accountId === $selectedWallet.mainAccountId
  ) || allAccountOutputs?.[0]
 
@@ -29,18 +31,24 @@
  class="w-full h-full flex flex-nowrap p-8 relative flex-1 bg-gray-50 dark:bg-gray-900 space-x-4 justify-center"
  >
  <div class="flex space-x-4 max-w-7xl justify-center w-full">
- {#key $selectedWallet?.id}
- {#if features.accountManagement.accountList.enabled}
- <AccountManagementList
- onAccountClick={handleAccountClick}
- allOutputs={allAccountOutputs}
- {selectedOutput}
- />
- {/if}
- {#if features.accountManagement.accountDetails.enabled}
- <AccountManagementDetails {selectedOutput} index={setAccountOutputIndex(selectedOutput)} />
- {/if}
- {/key}
+ {#if selectedOutput}
+ {#key $selectedWallet?.id}
+ {#if features.accountManagement.accountList.enabled}
+ <AccountManagementList
+ onAccountClick={handleAccountClick}
+ allOutputs={allAccountOutputs}
+ {selectedOutput}
+ />
+ {/if}
+ {#if features.accountManagement.accountDetails.enabled}
+ <AccountManagementDetails {selectedOutput} index={setAccountOutputIndex(selectedOutput)} />
+ {/if}
+ {/key}
+ {:else}
+ <div class="flex flex-col w-full h-full justify-center items-center">
+ <Text secondary>{localize('views.accountManagement.emptyAccounts')}</Text>
+ </div>
+ {/if}
  </div>
  </account-management-container>
 {/if}
diff --git a/packages/shared/locales/en.json b/packages/shared/locales/en.json
@@ -715,7 +715,8 @@
  "unsetAsPrimary": "Unset as primary"
  }
  },
- "notification": "Activate one account to access the dashboard."
+ "notification": "Activate one account to access the dashboard.",
+ "emptyAccounts": "There are no accounts to show, activate one first."
  },
  "delegation": {
  "title": "Delegation",