Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 001-20220404.md #14

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Add 001-20220404.md #14

merged 1 commit into from
Apr 3, 2022

Conversation

uhooi
Copy link
Member

@uhooi uhooi commented Apr 3, 2022

スクリーンショット

001 2022-04-04
スクリーンショット 2022-04-03 16 57 40

@uhooi uhooi self-assigned this Apr 3, 2022
treastrain
treastrain approved these changes Apr 3, 2022
View reviewed changes
Copy link
Member

@treastrain treastrain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

記事内容確認 & Swift 5.6 (Ubuntu Linux) で make run 確認しました！

Theme として「Twitter ツイート埋め込み」と「OGP カード表示」はサポートしておきたいですね… Publish の Theme カスタマイズでできそうでしょうか…。

crane-hiromu
crane-hiromu approved these changes Apr 3, 2022
View reviewed changes
Copy link
Contributor

@crane-hiromu crane-hiromu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ダウンロード

@uhooi uhooi merged commit 2e7799f into main Apr 3, 2022
@uhooi uhooi deleted the feature/001_20220404 branch April 3, 2022 12:36
@uhooi
Copy link
Member Author

uhooi commented Apr 3, 2022

みんなレビューありがとー！
cron に問題なければ明日の 9:00 に自動でデプロイされるはずなので、それを見届けたら Twitter に記事追加の投稿をします！

@uhooi
Copy link
Member Author

uhooi commented Apr 3, 2022

@treastrain

Theme として「Twitter ツイート埋め込み」と「OGP カード表示」はサポートしておきたいですね… Publish の Theme カスタマイズでできそうでしょうか…。

別 Issue に切り出すね！
ツイート埋め込みはプラグインを作っている人がいたから、それを使えばできるはず！
OGP もプラグインがあればできるけど、なければ実装が必要になる、、

@uhooi
Copy link
Member Author

uhooi commented Apr 4, 2022

@treastrain
遅くなったけど #17 と #18 で Issue を切り出したー！

@treastrain treastrain added this to the 001 milestone Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry-itto ry-itto ry-itto approved these changes

@crane-hiromu crane-hiromu crane-hiromu approved these changes

@treastrain treastrain treastrain approved these changes

Assignees

@uhooi uhooi

Labels
None yet
Projects
None yet
Milestone
001
Development

Successfully merging this pull request may close these issues.
4 participants
@uhooi @treastrain @crane-hiromu @ry-itto