Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

76 - Moved contact details to environment variables #84

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

Scilly-guy
Copy link
Contributor

Removed references to phone numbers and emails from templates and created context processor to add them to the context.
Dummy contact details are used if environment variables are not set.

@Scilly-guy
Copy link
Contributor Author

Fixes #76

Copy link
Member

@grundleborg grundleborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please remove the stripe dev keys, and can you make all the email/telephone ones clickable?

carshare/settings.py Outdated Show resolved Hide resolved
Copy link
Member

@grundleborg grundleborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grundleborg grundleborg merged commit be88cda into ios-cv:main Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants