Automated ER diagram generation #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggest updating read me to include instructions to install graphviz to enable ER diagram generation. |
grundleborg
requested changes
Dec 9, 2024
There was a problem hiding this comment.
This looks good. I have a couple of additional requests:
- Please can you add instructions (and a note on additional dependencies) to the README.md file.
- Please can you add all the files generated by this script to
.gitignoreso that they don't get accidentally checked in to the repo. - To make the above simpler and keep things tidier, I think you should create a subdirectory for the entity relationship diagram stuff, and move the
insert-diagram.pyandtemplate_entity_relatoinship_diagram.htmlfiles into it, as well as adjusting the generation commands to create all their files within that directory too. - You've added a dependency which means you'll need to run
poetry lock(I think) to updatepoetry.lockfile.
grundleborg
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added make command to refresh entity relationship diagram.